fix(docs-framework): let examples shrink to fit window width#5075
Merged
Conversation
Collaborator
thatblindgeye
approved these changes
Jul 15, 2026
thatblindgeye
left a comment
thatblindgeye
left a comment
Contributor
There was a problem hiding this comment.
Assuming it would have still been at exactly 1450px width, the original ToC bug doesnt seem to happen with this update (ToC goes from the collapsible view to the always-visible-on-the-right view when going from 1449px to 1450px width)
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5074
In #4802, the example area was given the change below, which added
min-width: 825px. That's keeping the examples from shrinking below 825pxI'm pretty sure that was to fix a bug on example pages that have narrow example content and no text that would make the example area fill the content width like this. AFAIK it only showed up on one example page, but I don't remember which example it was.
That said,
flex-grow: 1fixes that specific bug ^, so we can revert back to the old max-width and fix the bug caused by the new min-width.